From 6ebbc47396f5a440717cb7c82aa58fb34b4fa4db Mon Sep 17 00:00:00 2001
From: MK13 <marius@kleberonline.de>
Date: Thu, 19 Mar 2020 22:26:13 +0100
Subject: [PATCH] Set proper HTTP status codes for ResponseReasons

---
 .../main/java/de/financer/ResponseReason.java | 52 +++++++++----------
 1 file changed, 26 insertions(+), 26 deletions(-)

diff --git a/financer-common/src/main/java/de/financer/ResponseReason.java b/financer-common/src/main/java/de/financer/ResponseReason.java
index 30ef79c..9241edd 100644
--- a/financer-common/src/main/java/de/financer/ResponseReason.java
+++ b/financer-common/src/main/java/de/financer/ResponseReason.java
@@ -7,32 +7,32 @@ public enum ResponseReason {
     OK(HttpStatus.OK),
     CREATED(HttpStatus.CREATED),
     UNKNOWN_ERROR(HttpStatus.INTERNAL_SERVER_ERROR),
-    INVALID_ACCOUNT_TYPE(HttpStatus.INTERNAL_SERVER_ERROR),
-    FROM_ACCOUNT_NOT_FOUND(HttpStatus.INTERNAL_SERVER_ERROR),
-    TO_ACCOUNT_NOT_FOUND(HttpStatus.INTERNAL_SERVER_ERROR),
-    FROM_AND_TO_ACCOUNT_NOT_FOUND(HttpStatus.INTERNAL_SERVER_ERROR),
-    INVALID_DATE_FORMAT(HttpStatus.INTERNAL_SERVER_ERROR),
-    MISSING_DATE(HttpStatus.INTERNAL_SERVER_ERROR),
-    AMOUNT_ZERO(HttpStatus.INTERNAL_SERVER_ERROR),
-    MISSING_AMOUNT(HttpStatus.INTERNAL_SERVER_ERROR),
-    INVALID_BOOKING_ACCOUNTS(HttpStatus.INTERNAL_SERVER_ERROR),
-    MISSING_HOLIDAY_WEEKEND_TYPE(HttpStatus.INTERNAL_SERVER_ERROR),
-    INVALID_HOLIDAY_WEEKEND_TYPE(HttpStatus.INTERNAL_SERVER_ERROR),
-    MISSING_INTERVAL_TYPE(HttpStatus.INTERNAL_SERVER_ERROR),
-    INVALID_INTERVAL_TYPE(HttpStatus.INTERNAL_SERVER_ERROR),
-    MISSING_FIRST_OCCURRENCE(HttpStatus.INTERNAL_SERVER_ERROR),
-    INVALID_FIRST_OCCURRENCE_FORMAT(HttpStatus.INTERNAL_SERVER_ERROR),
-    INVALID_LAST_OCCURRENCE_FORMAT(HttpStatus.INTERNAL_SERVER_ERROR),
-    MISSING_RECURRING_TRANSACTION_ID(HttpStatus.INTERNAL_SERVER_ERROR),
-    INVALID_RECURRING_TRANSACTION_ID(HttpStatus.INTERNAL_SERVER_ERROR),
-    RECURRING_TRANSACTION_NOT_FOUND(HttpStatus.INTERNAL_SERVER_ERROR),
-    MISSING_TRANSACTION_ID(HttpStatus.INTERNAL_SERVER_ERROR),
-    INVALID_TRANSACTION_ID(HttpStatus.INTERNAL_SERVER_ERROR),
-    TRANSACTION_NOT_FOUND(HttpStatus.INTERNAL_SERVER_ERROR),
-    ACCOUNT_NOT_FOUND(HttpStatus.INTERNAL_SERVER_ERROR),
-    DUPLICATE_ACCOUNT_KEY(HttpStatus.INTERNAL_SERVER_ERROR),
-    DUPLICATE_ACCOUNT_GROUP_NAME(HttpStatus.INTERNAL_SERVER_ERROR),
-    ACCOUNT_GROUP_NOT_FOUND(HttpStatus.INTERNAL_SERVER_ERROR),
+    INVALID_ACCOUNT_TYPE(HttpStatus.BAD_REQUEST),
+    FROM_ACCOUNT_NOT_FOUND(HttpStatus.BAD_REQUEST),
+    TO_ACCOUNT_NOT_FOUND(HttpStatus.BAD_REQUEST),
+    FROM_AND_TO_ACCOUNT_NOT_FOUND(HttpStatus.BAD_REQUEST),
+    INVALID_DATE_FORMAT(HttpStatus.BAD_REQUEST),
+    MISSING_DATE(HttpStatus.BAD_REQUEST),
+    AMOUNT_ZERO(HttpStatus.BAD_REQUEST),
+    MISSING_AMOUNT(HttpStatus.BAD_REQUEST),
+    INVALID_BOOKING_ACCOUNTS(HttpStatus.BAD_REQUEST),
+    MISSING_HOLIDAY_WEEKEND_TYPE(HttpStatus.BAD_REQUEST),
+    INVALID_HOLIDAY_WEEKEND_TYPE(HttpStatus.BAD_REQUEST),
+    MISSING_INTERVAL_TYPE(HttpStatus.BAD_REQUEST),
+    INVALID_INTERVAL_TYPE(HttpStatus.BAD_REQUEST),
+    MISSING_FIRST_OCCURRENCE(HttpStatus.BAD_REQUEST),
+    INVALID_FIRST_OCCURRENCE_FORMAT(HttpStatus.BAD_REQUEST),
+    INVALID_LAST_OCCURRENCE_FORMAT(HttpStatus.BAD_REQUEST),
+    MISSING_RECURRING_TRANSACTION_ID(HttpStatus.BAD_REQUEST),
+    INVALID_RECURRING_TRANSACTION_ID(HttpStatus.BAD_REQUEST),
+    RECURRING_TRANSACTION_NOT_FOUND(HttpStatus.BAD_REQUEST),
+    MISSING_TRANSACTION_ID(HttpStatus.BAD_REQUEST),
+    INVALID_TRANSACTION_ID(HttpStatus.BAD_REQUEST),
+    TRANSACTION_NOT_FOUND(HttpStatus.BAD_REQUEST),
+    ACCOUNT_NOT_FOUND(HttpStatus.BAD_REQUEST),
+    DUPLICATE_ACCOUNT_KEY(HttpStatus.BAD_REQUEST),
+    DUPLICATE_ACCOUNT_GROUP_NAME(HttpStatus.BAD_REQUEST),
+    ACCOUNT_GROUP_NOT_FOUND(HttpStatus.BAD_REQUEST),
     PERIOD_ID_NOT_NUMERIC(HttpStatus.BAD_REQUEST),
     PERIOD_NOT_FOUND(HttpStatus.BAD_REQUEST),
     LIMIT_NOT_NUMERIC(HttpStatus.BAD_REQUEST),